On 11/11/2013 15:37, Michael McMahon wrote:
This is a fix to a test case that is failing on Windows.
A couple of problems:

1) cygwin doesn't like the newline at the end of the port number that gets printed to System.out

2) the calling script was not setting the classpath separator correctly (';' for windows)

http://cr.openjdk.java.net/~michaelm/8028060/webrev.1/

The ${PS} part looks fine. Changing LookupTest -getport to not emit a newline is okay too although I just worry that VM warnings or other output could be problematic.

So overall I think it's okay, but a good candidate to replace the shell tests with a pure java test at some point.

-Alan.

Reply via email to