Hi Tristan, I agree with you, option 2 is probably better.
Have you verified Kurchi's changes, tested, reviewed, etc? Have you modified Kurchi's changes from her original review request? I can sponsor this change. Thanks, -Chris. On 22/10/2013 07:22, Tristan Yan wrote:
Hi Everyone I have a fix for https://bugs.openjdk.java.net/browse/JDK-8022211, could you review it. Since we have Kurchi's code change out for review for re-writing this test to use the new HTTP Server API. We have 2 option here 1. Just fixing the bug with move setCondition around. 2. Adopting Kurchi's code change and my fix together as a whole fix. I propose we're using second way, the reason is Kruchi was using modern API of JDK, it's less error-prone and make test shorter, I'd like to shameless steal her fix as part of my fix. http://cr.openjdk.java.net/~pzhang/Tristan/8017779/webrev/ /Tristan Yan(Haibo Yan)/ /Office : 8610-61066212/ /Fax : 8610-61065441/ /Cell : 86-18610696822/ // /2F, Building No. 24, Zhongguancun Software Park/ /Haidian District Beijing <http://people.us.oracle.com/pls/oracle/f?p=8000:6:396067987304343:::6:P6_CITY:Beijing> , 100193/ oracle
