Michael: Right about the migration. You may be looking at a different webrev file that me? I made the new name: "TestHttpServer". (http://cr.openjdk.java.net/~chegar/6354758/webrev.00/test/java/net/Authenticator/B4722333.java.cdiff.html)
Thanks! John ----- Original Message ----- From: michael.x.mcma...@oracle.com To: john.zavg...@oracle.com Cc: net-dev@openjdk.java.net Sent: Wednesday, September 5, 2012 11:30:23 AM GMT -05:00 US/Canada Eastern Subject: Re: Review request for bug number: 6354758, aka "rename old test HttpServer classes" John, Maybe SimpleHttpsServer should be named TestHttpsServer to be similar to the Http equivalent. Otherwise, it looks fine to me. And I think we'll look into migrating these tests to use the com.sun.net.httpserver API instead of that old implementation in the test tree. Thanks Michael On 05/09/12 15:39, John Zavgren wrote: > Greetings: > > Please help to review the fix below for bug 6354758: > http://cr.openjdk.java.net/~chegar/6354758/webrev.00/ > > I changed the name of the class: ./test/sun/net/www/httptest/HttpServer.java > to: ./test/sun/net/www/httptest/TestHttpServer.java, > to eliminate a possible "name space collision". The server in the test code > (which is intended to be used ONLY for testing) has the same name as the > server that's used as an actual Http Server: > ./jdk/src/share/classes/com/sun/net/httpserver/HttpServer.java > > Thanks, > John Zavgren
