On 11/17/2011 04:57 AM, Chris Hegarty wrote:
On 11/16/11 01:48 AM, Charles Lee wrote:
On 11/16/2011 01:00 AM, Neil Richards wrote:
On Tue, 2011-11-15 at 19:37 +0800, Charles Lee wrote:
On 11/15/2011 07:10 PM, Chris Hegarty wrote:
On 11/15/11 06:57 AM, Charles Lee wrote:
....
Sigh. Chris, I still fail to see those warnings, even if I do a very
clean remove of my build directory and rebuild the whole jdk ....
The warning are being generated on Solaris when using the Sun
compilers ( both full and incremental builds ).
Here is the new (big) patch(attached) according to the comments
from you
and Mike. Thank you guys :-)
I can't apply the patch you sent. Is it possible to generate a
webrev,
another patch, or let me know how to apply the the one you sent?
Thanks,
-Chris.
Hi Chris,
patch -p0< mypatch under the jdk directory will do the trick.
I will try to find a solaris to test my patch.
Here is Charles' latest patch in webrev form [1].
Regards, Neil
[1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.02/
Thanks Neil.
Hi Chris,
With the latest patch, the warning of Inet4AddressImpl seems gone :-P (I
have reordered the statement and declaration). They used to happen on
the solaris indeed. Do you see other warnings now?
Thank you Charles, and Neil.
I ran some builds and tests and all looks good to me. Thanks for
fixing the warnings, I know they were not caused by your changes.
Just noticed that we haven't just filed a bug for this, so I just
created:
CR 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo
Neil,
I assume you will push this?
-Chris.
That's great. Thanks Chris. Thanks all.
--
Yours Charles
