On 08/11/11 05:27 PM, Alan Bateman wrote:
Chris Hegarty wrote:
Here is a first stab at fixing this issue.
http://cr.openjdk.java.net/~chegar/7014860/webrev.00/webrev/
-Chris.
The spec clarification seems reasonable to me. Small typo "the streams
available method" to "the stream's available method".
Ah yes, thanks.
Good to see the NIO socket adapter included in the test. One comment on
the test is that the Thread.dumpStack is a bit odd. It might be better
to pass in a test name into the test method and have that printed by the
failure message.
Yes, agreed. I did have this originally, but for some reason opted for
the more obscure dumpStack.
Updated webrev:
http://cr.openjdk.java.net/~chegar/7014860/webrev.01/webrev/
-Chris.
-Alan.
