On 03/24/11 10:55 AM, Alan Bateman wrote:
Chris Hegarty wrote:
Alan, Michael,
The subject line says it all! Nice to be able to remove this old code
that is no longer necessary. Hopefully this will make maintenance a
little easier going forward.
http://cr.openjdk.java.net/~chegar/7030256/webrev.00/webrev/
Mike Duigou noticed I pushed this webrev to cr.openjdk yesterday and
has already given feedback. Thanks Mike.
-Chris.
This looks a good cleanup to me. Lots of 95/98 crud in the repository
and always hard to get time to clear it out.
I guess the only concern is that net.dll will now require iphlpapi.dll.
Yes, we will now have a dependency on iphlpapi.dll, but this dll is part
of Windows since Windows 2000 and the functions we are using are all
available on XP. Does this address your concern, or do you have another
issue?
Minor comments:
src/windows/native/java/net/Inet6AddressImpl.c - you might need to
re-aligned line 344.
Got it. Thanks.
src/windows/native/java/net/net_util_md.c line - cast to jint???
I forgot to mention that I fixed a few compiler warning while I was
here. Are you referring to the casting of SOCKET s to jint, line 982?
SOCKET is an unsigned int pointer and needs an explicit cast. I thought
it was safe, and is what is done in Java_sun_nio_ch_Net_socket0.
-Chris.
