Alan Bateman wrote:
Chris Hegarty wrote:
Alan,

Don't assume sockets will default to dual stack, explicitly set IPV6_V6ONLY to 0. Apparently some Linux distros ship with net.ipv6.bindv6only=1 restricting sending and receiving to IPv6 packets only. Changes both net and nio code.

Webrev:
  http://cr.openjdk.java.net/~chegar/6882910/webrev.00/webrev/

Thanks,
-Chris.
The changes look okay to me. I assume the bulk of our existing tests will fail if we run on a system has IPV6_V6ONLY enabled by default (and

This is correct. We have many many failures of existing tests on platforms with IPV6_V6ONLY enabled by default.

so a new test isn't required for this fix). One small suggestion is just to add a comment to explain why the socket option needs to be disabled.

Updated webrev (added comment):
 http://cr.openjdk.java.net/~chegar/6882910/webrev.01/webrev/

Thanks,
-Chris.


-Alan.

Reply via email to