Chris Hegarty wrote:
Alan,
Can you please review these various updates to the jdk net regression
tests. Mainly closing of sockets, samevm issues, dial back of tests,
etc..
Webrev:
http://cr.openjdk.java.net/~chegar/6969395/webrev.00/webrev/
Thanks.
-Chris.
Good work! A few comments:
Should you leave the # jdk_net header in ProblemList.txt so that there
is a place to add networking tests in the future?
I notice you've changed a lot of http server tests to run in othervm
mode. Do they have to run in othervm mode? Just thinking about the
overall test time.
test/java/net/DatagramSocket/DatagramTimeout.java - I assume line 43 is
now needed as you have created sock already.
test/java/net/Socket/AccurateTimeout.java - I think the original bug
related to a delay of 500ms so increasing the tolerance may mean it
doesn't catch the original issue. Hard to know what to do with this
test; maybe it needs to run several times and pass if at least one
iteration is within tolerance. Alternatively maybe we should disable the
test?
test/java/net/Socket/SoTimeout.java - should you close serverSocket?
test/java/net/URLClassLoader/ClassLoad.java - minor bit but it looks
like the indentation in the handle method is inconsistent.
test/java/net/URLConnection/ZeroContentLength.java - are these changes
needed?
Otherwise the changes look fine to me.
-Alan.
