On 10/01/2010 16:27, Alan Bateman wrote:
....
If I understand correctly, you're trying to help the folks that want to take this code and hack on it with jdk6 - is that right?

Yes, this is correct.

Have you
considered creating a page on the SCTP project with the recipe.

This is a great idea.

Seems like removing the dependency on SocketOption and AlreadyBoundException are trivial and maybe there isn't a need to add commented out code. As the implementation is very tied to the selector implementation then I assume it's not an issue to keep the dependency on NativeDispatcher. That would avoid having to duplicate close/preClose at least. Otherwise looks okay to me.

The only reason I removed the dependency on NativeDispatcher is that its implementation invokes FileDispatcherImpl close & preClose, and this class was renamed in JDK7, from FileDispatcher. I decided to remove it as it was just another edit to make and the implementation was so trivial anyway.

-Chris.


-Alan.

Reply via email to