> - nitpick, the additional filesystem uses the --exclude-type argument, whilst > the squashfs exclusion uses -X. We should pick on (-X is a lot shorter and > tidier in my opinion) and stick to it, because otherwise it looks to someone > who is spinning up on this code as if they do different things. It hurts the > readability of the code. > > My suggestion is to convert to flags to all be '-X' instead of having one or > more -X and one or more --exclude-type flags - and to include as many virtual > filesystems as we see on a typically deployed Ubuntu system in supported > releases (Xenial, Bionic).
It is now harmonized. > At a minimum, I would expect us to exclude tracefs, debugfs, procfs, sysfs, > squashfs, cgroup, cgroup2, nsfs, hugetlbfs, bpf, devpts - there are others, > though. That now includes those FS. -- https://code.launchpad.net/~npochet/nagios-charm/+git/nagios-charm/+merge/371645 Your team Nagios Charm developers is subscribed to branch nagios-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to : [email protected] Unsubscribe : https://launchpad.net/~nagios-charmers More help : https://help.launchpad.net/ListHelp
