Review: Needs Fixing
Typo needs fixing. Other than that, +1.
Diff comments:
> diff --git a/hooks/templates/pagerduty_nagios_cfg.tmpl
> b/hooks/templates/pagerduty_nagios_cfg.tmpl
> index e5c8751..2a79de3 100644
> --- a/hooks/templates/pagerduty_nagios_cfg.tmpl
> +++ b/hooks/templates/pagerduty_nagios_cfg.tmpl
> @@ -16,11 +16,12 @@ define contact {
>
> define command {
> command_name notify-service-by-pagerduty
> - command_line /usr/local/bin/pagerduty_nagios.pl enqueue -f
> pd_nagios_object=service -q {{ pagerduty_path }}
> + command_line /usr/local/bin/pagerduty_nagios.pl enqueue {{
> proxy_switch }} -f pd_nagios_object=service -q {{ pagerduty_path }}
> }
>
> define command {
> command_name notify-host-by-pagerduty
> - command_line /usr/local/bin/pagerduty_nagios.pl enqueue -f
> pd_nagios_object=host -q {{ pagerduty_path }}
> + command_line /usr/local/bin/pagerduty_nagios.pl enqueue
> {{proxy_switch }} -f pd_nagios_object=host -q {{ pagerduty_path }}
I think "proxy_switch" needs a space on the left side: "{{ proxy_switch }}"
instead of "{{proxy_switch }}".
> +
> }
>
--
https://code.launchpad.net/~aieri/nagios-charm/+git/nagios-charm/+merge/366303
Your team Nagios Charm developers is subscribed to branch nagios-charm:master.
--
Mailing list: https://launchpad.net/~nagios-charmers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~nagios-charmers
More help : https://help.launchpad.net/ListHelp
