Review: Approve lgtm. Please take a look to this MP[1] to consider addressing the use of deprecated charmtools variables in favor of the new ones. If so, CHARM_BUILD_DIR needs to be used in tox.ini and function/test_deploy.py as in [2].
1. https://code.launchpad.net/~aluria/template-python-pytest/+git/template-python-pytest/+merge/364040 2. https://code.launchpad.net/~aluria/grafana-charm/+git/grafana-charm-1/+merge/364044 -- https://code.launchpad.net/~aieri/hw-health-charm/+git/hw-health-charm/+merge/364758 Your team Nagios Charm developers is subscribed to branch hw-health-charm:oo-rewrite-integration. -- Mailing list: https://launchpad.net/~nagios-charmers Post to : [email protected] Unsubscribe : https://launchpad.net/~nagios-charmers More help : https://help.launchpad.net/ListHelp
