> After grepping *.{c,h}, it seems that Mutt doesn't use FP, except in
> sendlib.c here:
>
> /* Determine which encoding is smaller */
> if (1.33 * (float)(info->lobin+info->hibin+info->ascii) < 3.0 * (float)
>(info->lobin + info->hibin) + (float)info->ascii)
>
> BTW, why is there a cast to float? A cast to double (or nothing) would
> IMHO be more efficient, as 1.33 and 3.0 are doubles.
You shouldn't be using floating-point at all for a simple calculation
like that. I bet you don't really mean "1.33" anyway. What's wrong
with ((info->lobin + info->hibin + info->ascii)*4/3 < (info->lobin +
info->hibin)*3 + info->ascii)?
On an unrelated gripe: would it be a good idea to replace all
references to ctype functions, such as isspace, by a mutt function or
macro that doesn't depend on the locale? The definitions in RFC-822,
etc aren't supposed to depend on the locale.
Edmund
