Re: [PATCH] Fix IMAP auth_crm MD5 digest of secret to use memcpy().

[Kevin J. McCarthy]

On Sun, Apr 19, 2026 at 05:08:29PM +0200, Rene Kita wrote:

On Sun, Apr 19, 2026 at 01:50:51PM +0800, Kevin J. McCarthy wrote:

For a secret longer that MD5_BLOCK_LEN, an MD5 digest is used

s/that/than

Ack.  Thank you.

The part after the else above is:
 strfcpy((char *) secret, password, sizeof(secret));

Are we dealing here with strings or with buffers of bytes/chars?

--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

Alex answered, but just to concur. We are dealing with bytes for the output of md5_buffer(). But the password parameter is a string.

signature.asc
Description: PGP signature