On Wed, Aug 11, 2021 at 03:02:30PM -0400, Craig Gallek wrote:
This already worked when compiled against openssl, but not with gnutls.
Looks like this is based on the OpenSSL calls. If you can verify it works for you, I have no problem with the patch.
I figured it would be good to get some early feedback on this, though. In particular, do you care that this duplicates a translation string? It could certainly be put in a common place, but I wasn't sure where.
It's not a problem to duplicate translation strings, so this is fine.
This change is safe with or without the gnutls change. It simply won't call the prompt callback with older versions of gnutls (though, it's proabably best to wait for that change anyway to ensure that this callback mechanism will be the one actually used).
I agree. Let's wait until your merge request is accepted. If you wouldn't mind sending a followup email then, I'll be glad to merge it at that point.
-- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
