On Mon, May 11, 2020 at 06:56:05PM -0500, Derek Martin wrote: > On Fri, May 08, 2020 at 06:59:18AM +0200, Petr Pisar wrote: > > On Fri, May 08, 2020 at 06:42:57AM +0200, Claus Assmann wrote: > > > On Thu, May 07, 2020, Remco Rijnders wrote: > > > > > > > - dprint (1, (debugfile, "WEED is %s\n", (flags & CH_WEED) ? "Set" : > > > > "Not")); > > > > + dprint (1, (debugfile, "WEED is %s\n", (flags & CH_WEED) ? "Set" : > > > > "Not Set")); > > > > > > Save some bytes:-) > > > > > > dprint (1, (debugfile, "WEED is %sSet\n", (flags & CH_WEED) ? "" : "Not > > > ")); > > > > The message probably does not get translated, but from point of view of > > localization, please do not glue sentences from words. > > Can you not just translate both parts? > If the parts are not marked for translation, and that is this case, then they won't be translated. However, somebody can come later seeing an untranslated message and thinking he does good mark it for translation, and the problem emerges. I only wanted proactively prevent fututure bugs.
Ideal code will do:
dprint (1, (debugfile, (flags & CH_WEED) ? "WEED is Set" : "WEED is Not
Set"));
The complete sentences also help discover that the capitalization is
incorrectly used because this is a mere line in a debug log, not a title. And
also help discover that a full-stop mark is missing at the end.
-- Petr
signature.asc
Description: PGP signature
