On Sun, Apr 19, 2020 at 04:28:02PM -0400, Remco Rijnders wrote:
When converting binary values to Base 64 encoding, we go from a 8 bit representation to a 6 bit representation. As a result, we need extra space to store the result compared to the input value being converted.In the current implementation, the requirements on the size of the output buffer are too conservative; We only have to check if the remaining space is larger than 4 (3 input bytes get converted into 4 Base64 encoded output bytes, plus allowing for a terminating '\0' character) rather than 10.
I think you're right, but FYI that during the freeze I'm not looking at these kind of patches. I'll take a closer look after the release.
-- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
