On Sat, Sep 15, 2018 at 11:23:55AM -0400, John Hawkinson wrote: > I wonder if there's any appetite for reducing the default > "imap_keepalive," either uncondionally all the time [...] or > adaptively in response to servers identifying themselves
I feel your pain, but 5 minutes is way below the RFC specified minimum. I think likely the admins of the server dropped the timeout value to reduce load. Sniffing server identifiers and adjusting configs based on that wouldn't be somewhere I want to take the code. > In any case, defaults aside, it appears there are a few other places > where IMAP keepalives aren't being sent. The primary one that I hit is > when an external interactive viewer is launched (e.g. w3m for html > email) Peeking in the function myself, in the "normal" case where the mailcap contains a '%s', Mutt calls mutt_system(), which would send keepalives. However, if the mailcap entry is missing a '%s' filename specifier, I see Mutt instead pipes the message on stdin uses the filter code. The patch looks fine, but I wonder if we need to apply this hammer to every filter. Filters are (supposed to be) short lived and produce output back into Mutt for display; I think this may be the only case in the code where we a using it to launch an external program for interaction. Perhaps it would be better to just adjust the "is_pipe" case for mutt_view_attachment(). Please give me a few days to look into that first. Thank you, -Kevin -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
