On Tue, May 08, 2018 at 12:30:51PM +0200, Moritz Barsnick wrote: > On Tue, Feb 27, 2018 at 01:56:28 -0000, Mutt wrote: > > As it is hard (and makes less to no sense) to support IDNA2003 and > > IDNA2008 in parallel, I would recommend to replace IDNA2003 by IDNA2008 > > support, which means that the requirement in the end switches over from > > libidn to libidn2 simply. > > This is probably still very welcome, e.g. for mutt-1.10 (wow, are we > there already, it seems like only yesterday we were stuck at 1.4.xx > forever ;->). > > The patch, which you integrated into the Fedora package, as I noticed, > it not completely correct syntactically, as it continues to use the > legacy return code checks (IDNA_SUCCESS) while libidn2 provides its own > (e.g. IDN2_OK). Pre-2017 versions of libidn2 didn't provide the legacy > enums.
Hi Moritz, Thanks for the heads-up. I wasn't aware they added the compatibility functions so recently. I'm not going to change the code, because we're supporting both, but it sounds like the checks in configure.ac need to verify the compat functions exist. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
