changeset: 7105:9430d2357bc2 user: Brendan Cully <bren...@kublai.com> date: Thu Jul 13 22:05:28 2017 -0700 link: http://dev.mutt.org/hg/mutt/rev/9430d2357bc2
drop unused flags argument from imap_access We are not using an actual interface so it is pointless. diffs (72 lines): diff -r 742c96078159 -r 9430d2357bc2 imap/imap.c --- a/imap/imap.c Wed Jul 12 21:20:24 2017 -0700 +++ b/imap/imap.c Thu Jul 13 22:05:28 2017 -0700 @@ -55,7 +55,7 @@ /* imap_access: Check permissions on an IMAP mailbox. * TODO: ACL checks. Right now we assume if it exists we can * mess with it. */ -int imap_access (const char* path, int flags) +int imap_access (const char* path) { IMAP_DATA* idata; IMAP_MBOX mx; @@ -809,8 +809,7 @@ strfcpy (mailbox, "INBOX", sizeof (mailbox)); FREE (&mx.mbox); - /* really we should also check for W_OK */ - if ((rc = imap_access (ctx->path, F_OK)) == 0) + if ((rc = imap_access (ctx->path)) == 0) return 0; if (rc == -1) diff -r 742c96078159 -r 9430d2357bc2 imap/imap.h --- a/imap/imap.h Wed Jul 12 21:20:24 2017 -0700 +++ b/imap/imap.h Thu Jul 13 22:05:28 2017 -0700 @@ -1,21 +1,21 @@ /* * Copyright (C) 1996-1998 Michael R. Elkins <m...@mutt.org> * Copyright (C) 2000-2007 Brendan Cully <bren...@kublai.com> - * + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. - * + * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * + * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - */ + */ #ifndef _IMAP_H #define _IMAP_H 1 @@ -32,7 +32,7 @@ } IMAP_MBOX; /* imap.c */ -int imap_access (const char*, int); +int imap_access (const char *path); int imap_check_mailbox (CONTEXT *ctx, int *index_hint, int force); int imap_delete_mailbox (CONTEXT* idata, IMAP_MBOX mx); int imap_sync_mailbox (CONTEXT *ctx, int expunge, int *index_hint); diff -r 742c96078159 -r 9430d2357bc2 mx.c --- a/mx.c Wed Jul 12 21:20:24 2017 -0700 +++ b/mx.c Thu Jul 13 22:05:28 2017 -0700 @@ -499,7 +499,7 @@ { #ifdef USE_IMAP if (mx_is_imap (path)) - return imap_access (path, flags); + return imap_access (path); #endif return access (path, flags);