On Tue, Jun 20, 2017 at 03:47:50PM -0700, Kevin J. McCarthy wrote: > The most recent commit (219b9064cf28) added a sigprocmask blocking > SIGWINCH during connect(), because FreeBSD was interrupting in that > case.
Why block the signal? Why not just handle EINTR when connect() returns? Has these advantages: - Is valid C code on every platform Mutt runs on, so no special-case - Does not need to care about (or think about) any #defines - it does not interfere with signal delivery, so redraw will behave (approximately) the same way across platforms regardless of SA_RESTART semantics Downsides? I can't think of any. -- Derek D. Martin http://www.pizzashack.org/ GPG Key ID: 0xDFBEAD02 -=-=-=-=- This message is posted from an invalid address. Replying to it will result in undeliverable mail due to spam prevention. Sorry for the inconvenience.
pgpBi67aMYnai.pgp
Description: PGP signature
