#3899: mutt_ssl's interactive_check_cert() has several issues
-----------------------+----------------------
Reporter: kevin8t8 | Owner: mutt-dev
Type: defect | Status: closed
Priority: major | Milestone:
Component: crypto | Version:
Resolution: fixed | Keywords:
-----------------------+----------------------
Comment (by derekmartin):
Replying to [comment:27 vinc17]:
> With this helper function, doesn't the array disappear completely?
However the value of {{{menu->max}}} would depend on the contents of the
helper function,
which is quite bad (the helper function would no longer be a black box
from the outside).
It's a helper function... it doesn't need to. The two are meant to go
together. It's like friend classes in C++. It's not inherently bad.
> To avoid {{{menu->max}}}, a different structure could be used than a
fixed-size array for {{{menu->dialog}}}, and IMHO, this should be hidden
in {{{menu.c}}}, everything being handled via function calls. Well, this
would mean to change a large part of the code...
This seems good. It's more work but if we all agree the code is generally
not great then that should be a goal anyway, no? :)
--
Ticket URL: <https://dev.mutt.org/trac/ticket/3899#comment:29>
Mutt <http://www.mutt.org/>
The Mutt mail user agent
