#3899: mutt_ssl's interactive_check_cert() has several issues
-----------------------+----------------------
Reporter: kevin8t8 | Owner: mutt-dev
Type: defect | Status: new
Priority: major | Milestone:
Component: crypto | Version:
Resolution: | Keywords:
-----------------------+----------------------
Comment (by kevin8t8):
Funnily enough I just asked Damien not to use that construct, because
we're not generally using it in mutt. Now that I look closer, I do see a
couple places in init.c and keymap.c, but there is still something I don't
like about it...
A problem is the menu structure is fragile too. It currently hard codes
the max size and pre-allocates it. So if you increase the number of
parts, you have to remember to increase the max size right now. I didn't
want to change too much in the function, so I took the easy way out.
Perhaps a compromise is to set
menu->max = numberof(parts) * 2 + 9;
for now.
--
Ticket URL: <https://dev.mutt.org/trac/ticket/3899#comment:3>
Mutt <http://www.mutt.org/>
The Mutt mail user agent
