#3870: openssl 1.1
----------------------+----------------------
Reporter: tamo | Owner: mutt-dev
Type: task | Status: closed
Priority: trivial | Milestone:
Component: build | Version: 1.7.0
Resolution: fixed | Keywords: ssl
----------------------+----------------------
Comment (by kevin8t8):
Thanks Vincent. Just to note, I looked in the openssl source (for
versions v1.1, 1.0.2, and 1.0.1) before making this change.
{{{X509_NAME_oneline}}} decrements the buflen parameter by one internally
(to leave space for the null-terminator), and does null-terminate the
buffer even in the event the length is not long enough.
I also noted the "strongly discouraged" label, but I agree this isn't
critical for debugging.
Unfortunately, we are also using this function in our
interactive_check_cert() function, so there might be an issue there.
Also, the 1.0.2 and 1.0.1 versions used {{{OPENSSL_free}}} internally for
freeing the return value (inside crypto/asn1/x_x509.c}.
--
Ticket URL: <https://dev.mutt.org/trac/ticket/3870#comment:7>
Mutt <http://www.mutt.org/>
The Mutt mail user agent