On Tue, Oct 04, 2016 at 03:19:55PM -0700, Kevin J. McCarthy wrote:
> On Tue, Oct 04, 2016 at 02:31:58PM -0700, Kevin J. McCarthy wrote:
> > On Tue, Oct 04, 2016 at 10:38:57PM +0200, Petr Pisar wrote:
> > > When I was updating po/mutt.pot locally, I noticed the sidebar messages 
> > > (e.g.
> > > "move the highlight to next mailbox") get removed from the mutt.pot. I'm 
> > > not
> > > sure whether this is desired.
> > 
> > No, this shouldn't be happening.  I'm seeing the message in my copy of
> > mutt.pot, but perhaps this is because I have --enable-sidebar when I
> > configure.  I'll see if I can figure out the problem.
> 
> No, it doesn't seem to have anything to do with the configuration
> options.  It should be grabbing those messages from keymap_alldefs.h.
> 
> What happens if you rm keymap_alldefs.h and then rerun 'cd po;make
> mutt.pot'?
> 
That's it. I updated sources from hg, then run autoreconf and then "make -C po
mutt.pot". Because I had old keymap_alldefs.h, the po/Makefile was satisfied
despide being outdated. The result was mutt.pot without some messages.
Running "make keymap_alldefs.h" before regenerating mutt.pot helped.

Maybe if the po/Makefile.in.in declared the $(top_builddir)/keymap_alldefs.h
as a phony target, it would run "( cd $(top_builddir) && $(MAKE)
keymap_alldefs.h )" anytime, and that means the keymap_alldefs.h were always
attempted to rebuild. And to prevent from rewriting the file (and thus
confusing other rules from top-level Makefile.am), the ./Makefile.am could
remove the "rm -f $@" command.

But that's probably too hassle for such a corner case. I will try to remember to
build the sources before updating translation next time.

Attached is a patch with the translation based on this time complete mutt.pot.
It's again diff against hg commit 8262503d1991.

-- Petr

Attachment: mutt-8262503d1991-cs.diff.gz
Description: Binary data

Attachment: signature.asc
Description: PGP signature

Reply via email to