* On 30 Aug 2016, Oswald Buddenhagen wrote: > > When $flag_safe is set, flagged messages cannot be deleted. > > > note that many of your patches have a "malformed" summary: you should > use imperative (or simple past, but kevin appears to prefer the former). > you're supposed to describe a transition, not a state.
That's ideal for a bug fix. It works less for new capability, where describing the transition from a code perspective doesn't really tell you anything since the prior state didn't exist. Unless you're suggesting simply "Add $flag_safe." I'm OK with that, but see below. > > This saves them from bulk operations on threads and tagged messages. To > > remove a flagged message, first unflag it. > > > this belongs into the documentation, not so much the commit message. It's in the documentation. I think it's useful to describe new features in the first commit message as well. I'll note that you disagree. :) > i'll go through all the patches as time permits. it won't be a terribly > thorough review, though. Thanks. -- David Champion • d...@bikeshed.us
