On Wed, Jun 08, 2016 at 04:31:06PM +0100, Richard Russon wrote: > Several of the compose-panel labels didn't use the TITLE_FMT to align > themselves. This causes formatting problems when the width is changed, > e.g. by the NNTP patch.
Hi Rich,
Thanks for the patch. I have three comments/questions below. If you
let me know your opinion on #2 below, I'll be glad to make the changes
for #1 and 3. Or you can send another patch if you want to.
> - printw ("%s%s", _(" sign as: "), PgpSignAs ? PgpSignAs : _("<default>"));
> + printw (TITLE_FMT "%s", _(" sign as: "), PgpSignAs ? PgpSignAs :
> _("<default>"));
> - printw ("%s%s", _(" sign as: "), SmimeDefaultKey ? SmimeDefaultKey :
> _("<default>"));
> + printw (TITLE_FMT "%s", _(" sign as: "), SmimeDefaultKey ?
> SmimeDefaultKey : _("<default>"));
If we change these two to use TITLE_FMT, we should probably remove the
leading space.
> if ((WithCrypto & APPLICATION_SMIME)
> @@ -162,7 +162,7 @@ static void redraw_crypt_lines (HEADER *msg)
> && (msg->security & ENCRYPT)
> && SmimeCryptAlg
> && *SmimeCryptAlg) {
> - mutt_window_mvprintw (MuttIndexWindow, HDR_CRYPTINFO, 40, "%s%s",
> _("Encrypt with: "),
> + mutt_window_mvprintw (MuttIndexWindow, HDR_CRYPTINFO, 40, TITLE_FMT
> "%s", _("Encrypt with: "),
> NONULL(SmimeCryptAlg));
Since this is printed in column 40, do we need to add TITLE_FMT here?
> - mutt_window_mvaddstr (MuttIndexWindow, HDR_MIX, 0, " Mix: ");
> + mutt_window_mvprintw (MuttIndexWindow, HDR_MIX, 0, TITLE_FMT, "Mix: ");
We should probably tag this string for translation. Since "Mix: " is
rather vague, I'd add a L10N comment just above it.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
