On Mon, May 09, 2016 at 10:34:03PM -0400, Damien Riegel wrote:
> Changes in v2:
> - Addressed styling issues
> - Got rid of the probing logic. For now, we still rely on a switch case
> to retrieve the correct mx_ops. So, one switch case was remove and
> another one was added, but as more functions will be added in the
> struct mx_ops, we will get rid of more {switch,if}(ctx->magic). This
> is only the first step!
> - Removed patches that changed mx_fastclose_mailbox
> - Folded similar patches into larger commits
Hi Damien,
Well, I think this is a good start. I'm inclined to commit this, unless
anyone has objections.
Some things I would like to see changed in your next patch:
* The structs in imap.c, mbox.c, mh.c, pop.c still have
the wrong style ("struct {" instead of "struct\n{")
* I would also like to see those structs moved to near the top of the
various files, rather than being buried in the middle of them.
(Yes, this means you'll have to add some function prototypes for the
static functions.)
* Lastly, I'd like the
extern struct mx_ops mx_*_ops;
declarations moved inside mx.h, pop.h, and imap.h.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
