On Monday, 27 July 2009 at 10:19, Matthias Andree wrote: > Am 24.07.2009, 14:14 Uhr, schrieb Rocco Rutte <pd...@gmx.net>: > > >Hi, > > > >* Matthias Andree wrote: > > > >>You wouldn't be telling this to users, but to developers. Only those > >>checking out from Mercurial will need to run autoconf. > > > >Hmm, right. > > > >>For developers, we can bump AC_PREREQ([2.54]) to AC_PREREQ([2.60]) so > >>that older autoconf versions refuse operation. That would make sure > >>that all "make dist" tarballs support --docdir from that point in > >>time forward. > > > >Yes, I'm perfectly fine with this, but I'm not sure Brendan is. He's the > >maintainer and I think I won't push the patch without his ACK because he > >vetoed already once (dropping --with-docdir altogether, not sure what he > >thinks about the deprecation warning and bumping required autoconf). > > Dear Rocco, Brendan, list lurkers, > > I'm open to removing or rewording the warning. > > The current logic is: > > 1st check if --with-docdir is given. If yes, use that and print a > deprecation warning (we should perhaps at least tell the user that > the option was accepted, but may be going away in 1.8 and keep it > supported through 1.6.x), accept the option, and override --docdir > (i. e. --docdir is ignored when --with-docdir is used). > > 2nd check (now --with-docdir/--without-docdir were not given) for > regular autoconf 2.60+ logic. > > 3rd go with the autoconf default. > > > So we're fully compatible with traditional mutt configure scripts > that used to use --with-docdir (albeit printing a warning), and also > with the GNU coding standards (supporting --docdir if people use > that, and assume that those who use --docdir will usually not use > > > So Brendan, we're looking forward to your reply :-)
My feeling is that it isn't really worth bumping AC_PREREQ at this late stage just for this flag (I will be happy to bump it after 1.6). I would gladly take a patch that: * does not require 2.60 * accepts --with-docdir without complaint * accepts --docdir if that variable is set * gives an error if _both_ docdir and with-docdir are set. In other words, it accepts the new --docdir flag if it's available, but doesn't disturb any existing users.
