Author: spouliot
Date: 2008-02-10 14:30:47 -0500 (Sun, 10 Feb 2008)
New Revision: 95398
Modified:
trunk/mcs/class/System.Design/System.Web.UI.Design/ChangeLog
trunk/mcs/class/System.Design/System.Web.UI.Design/DataFieldConverter.cs
trunk/mcs/class/System.Design/System.Web.UI.Design/DataMemberConverter.cs
trunk/mcs/class/System.Design/System.Web.UI.Design/DataSourceConverter.cs
Log:
2008-02-10 Sebastien Pouliot <[EMAIL PROTECTED]>
* DataFieldConverter.cs, DataMemberConverter.cs, DataSourceConverter.cs:
Use 'is' instead of 'as' and a null check. Found using Gendarme new
UseIsOperator rule.
Modified: trunk/mcs/class/System.Design/System.Web.UI.Design/ChangeLog
===================================================================
--- trunk/mcs/class/System.Design/System.Web.UI.Design/ChangeLog
2008-02-10 18:45:09 UTC (rev 95397)
+++ trunk/mcs/class/System.Design/System.Web.UI.Design/ChangeLog
2008-02-10 19:30:47 UTC (rev 95398)
@@ -1,3 +1,9 @@
+2008-02-10 Sebastien Pouliot <[EMAIL PROTECTED]>
+
+ * DataFieldConverter.cs, DataMemberConverter.cs, DataSourceConverter.cs:
+ Use 'is' instead of 'as' and a null check. Found using Gendarme new
+ UseIsOperator rule.
+
2007-10-09 Atsushi Enomoto <[EMAIL PROTECTED]>
* HtmlControlDesigner.cs, WebControlToolboxItem.cs,
Modified:
trunk/mcs/class/System.Design/System.Web.UI.Design/DataFieldConverter.cs
===================================================================
--- trunk/mcs/class/System.Design/System.Web.UI.Design/DataFieldConverter.cs
2008-02-10 18:45:09 UTC (rev 95397)
+++ trunk/mcs/class/System.Design/System.Web.UI.Design/DataFieldConverter.cs
2008-02-10 19:30:47 UTC (rev 95398)
@@ -68,7 +68,7 @@
public override bool GetStandardValuesSupported
(ITypeDescriptorContext context)
{
- return ((context.Instance as IComponent) != null);
+ return (context.Instance is IComponent);
}
}
}
Modified:
trunk/mcs/class/System.Design/System.Web.UI.Design/DataMemberConverter.cs
===================================================================
--- trunk/mcs/class/System.Design/System.Web.UI.Design/DataMemberConverter.cs
2008-02-10 18:45:09 UTC (rev 95397)
+++ trunk/mcs/class/System.Design/System.Web.UI.Design/DataMemberConverter.cs
2008-02-10 19:30:47 UTC (rev 95398)
@@ -68,7 +68,7 @@
public override bool GetStandardValuesSupported
(ITypeDescriptorContext context)
{
- return ((context.Instance as IComponent) != null);
+ return (context.Instance is IComponent);
}
}
}
Modified:
trunk/mcs/class/System.Design/System.Web.UI.Design/DataSourceConverter.cs
===================================================================
--- trunk/mcs/class/System.Design/System.Web.UI.Design/DataSourceConverter.cs
2008-02-10 18:45:09 UTC (rev 95397)
+++ trunk/mcs/class/System.Design/System.Web.UI.Design/DataSourceConverter.cs
2008-02-10 19:30:47 UTC (rev 95398)
@@ -68,7 +68,7 @@
public override bool GetStandardValuesSupported
(ITypeDescriptorContext context)
{
- return ((context.Instance as IComponent) != null);
+ return (context.Instance is IComponent);
}
#if NET_2_0
_______________________________________________
Mono-patches maillist - [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches
