Author: nestor
Date: 2008-02-07 12:01:33 -0500 (Thu, 07 Feb 2008)
New Revision: 95155
Modified:
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/ChangeLog
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/DisposableTypesShouldHaveFinalizerRule.cs
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/FinalizersShouldBeProtectedRule.cs
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/FinalizersShouldCallBaseClassFinalizerRule.cs
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/Test/ChangeLog
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/Test/FinalizersShouldCallBaseClassFinalizerTest.cs
Log:
2008-02-07 Nestor Salceda <[EMAIL PROTECTED]>
* DisposableTypesShouldHaveFinalizerRule.cs,
FinalizersShouldCallBaseClassFinalizerRule.cs,
FinalizersShouldBeProtectedRule.cs: Replaced
TypeDefinition.GetFinalizer
with TypeDefinition.GetMethod for avoid some warnings when compiling.
* Test/FinalizersShouldCallBaseClassFinalizerTest.cs:Replaced
TypeDefinition.GetFinalizer
with TypeDefinition.GetMethod for avoid some warnings when compiling.
Modified: trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/ChangeLog
===================================================================
--- trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/ChangeLog
2008-02-07 16:47:43 UTC (rev 95154)
+++ trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/ChangeLog
2008-02-07 17:01:33 UTC (rev 95155)
@@ -1,3 +1,10 @@
+2008-02-07 Nestor Salceda <[EMAIL PROTECTED]>
+
+ * DisposableTypesShouldHaveFinalizerRule.cs,
+ FinalizersShouldCallBaseClassFinalizerRule.cs,
+ FinalizersShouldBeProtectedRule.cs: Replaced TypeDefinition.GetFinalizer
+ with TypeDefinition.GetMethod for avoid some warnings when compiling.
+
2008-01-29 Sebastien Pouliot <[EMAIL PROTECTED]>
* ProvideAlternativeNamesForOperatorOverloadsRule.cs: Change
Modified:
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/DisposableTypesShouldHaveFinalizerRule.cs
===================================================================
---
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/DisposableTypesShouldHaveFinalizerRule.cs
2008-02-07 16:47:43 UTC (rev 95154)
+++
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/DisposableTypesShouldHaveFinalizerRule.cs
2008-02-07 17:01:33 UTC (rev 95155)
@@ -39,7 +39,7 @@
{
if (!type.Implements ("System.IDisposable"))
return runner.RuleSuccess;
- if (type.GetFinalizer () != null)
+ if (type.GetMethod (MethodSignatures.Finalize) != null)
return runner.RuleSuccess;
foreach (FieldDefinition field in type.Fields) {
Modified:
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/FinalizersShouldBeProtectedRule.cs
===================================================================
---
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/FinalizersShouldBeProtectedRule.cs
2008-02-07 16:47:43 UTC (rev 95154)
+++
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/FinalizersShouldBeProtectedRule.cs
2008-02-07 17:01:33 UTC (rev 95155)
@@ -39,7 +39,7 @@
public MessageCollection CheckType (TypeDefinition
typeDefinition, Runner runner)
{
- MethodDefinition finalizer =
typeDefinition.GetFinalizer ();
+ MethodDefinition finalizer = typeDefinition.GetMethod
(MethodSignatures.Finalize);
if (finalizer == null) // no finalizer found
return runner.RuleSuccess;
Modified:
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/FinalizersShouldCallBaseClassFinalizerRule.cs
===================================================================
---
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/FinalizersShouldCallBaseClassFinalizerRule.cs
2008-02-07 16:47:43 UTC (rev 95154)
+++
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/FinalizersShouldCallBaseClassFinalizerRule.cs
2008-02-07 17:01:33 UTC (rev 95155)
@@ -43,7 +43,7 @@
if (typeDefinition.BaseType == null)
return runner.RuleSuccess;
- MethodDefinition finalizer =
typeDefinition.GetFinalizer ();
+ MethodDefinition finalizer = typeDefinition.GetMethod
(MethodSignatures.Finalize);
if (finalizer == null) // no finalizer found
return runner.RuleSuccess;
Modified: trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/Test/ChangeLog
===================================================================
--- trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/Test/ChangeLog
2008-02-07 16:47:43 UTC (rev 95154)
+++ trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/Test/ChangeLog
2008-02-07 17:01:33 UTC (rev 95155)
@@ -1,3 +1,8 @@
+2008-02-07 Nestor Salceda <[EMAIL PROTECTED]>
+
+ * FinalizersShouldCallBaseClassFinalizerTest.cs:Replaced
TypeDefinition.GetFinalizer
+ with TypeDefinition.GetMethod for avoid some warnings when compiling.
+
2008-01-29 Sebastien Pouliot <[EMAIL PROTECTED]>
* ProvideAlternativeNamesForOperatorOverloadsTest.cs: Add
Modified:
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/Test/FinalizersShouldCallBaseClassFinalizerTest.cs
===================================================================
---
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/Test/FinalizersShouldCallBaseClassFinalizerTest.cs
2008-02-07 16:47:43 UTC (rev 95154)
+++
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design/Test/FinalizersShouldCallBaseClassFinalizerTest.cs
2008-02-07 17:01:33 UTC (rev 95155)
@@ -84,7 +84,7 @@
public void TestNonProtectedFinalizerDefinedClass ()
{
TypeDefinition typeDefinition =
GetTest<FinalizerCallingBaseFinalizerClass> ().Clone () as TypeDefinition;
- MethodDefinition finalizer =
typeDefinition.GetFinalizer ();
+ MethodDefinition finalizer = typeDefinition.GetMethod
(MethodSignatures.Finalize);
// make it non-protected (e.g. public)
finalizer.IsPublic = true;
_______________________________________________
Mono-patches maillist - [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches
