Author: nestor
Date: 2008-02-07 12:20:33 -0500 (Thu, 07 Feb 2008)
New Revision: 95159
Modified:
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/ChangeLog
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/CodeDuplicatedLocator.cs
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/Expression.cs
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/ExpressionFillerVisitor.cs
Log:
2008-07-07 Nestor Salceda <[EMAIL PROTECTED]>
* ExpressionFillerVisitor.cs, CodeDuplicatedLocator.cs, Expression.cs:
For performance issues types which aren't visible outside of the
assembly and haven't subclasses should be sealed.
Modified: trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/ChangeLog
===================================================================
--- trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/ChangeLog
2008-02-07 17:20:33 UTC (rev 95158)
+++ trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/ChangeLog
2008-02-07 17:20:33 UTC (rev 95159)
@@ -1,3 +1,9 @@
+2008-07-07 Nestor Salceda <[EMAIL PROTECTED]>
+
+ * ExpressionFillerVisitor.cs, CodeDuplicatedLocator.cs, Expression.cs:
+ For performance issues types which aren't visible outside of the
+ assembly and haven't subclasses should be sealed.
+
2008-02-07 Nestor Salceda <[EMAIL PROTECTED]>
* AvoidLongMethodsRule.cs: As suggested by Sebastien, the new
Modified:
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/CodeDuplicatedLocator.cs
===================================================================
---
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/CodeDuplicatedLocator.cs
2008-02-07 17:20:33 UTC (rev 95158)
+++
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/CodeDuplicatedLocator.cs
2008-02-07 17:20:33 UTC (rev 95159)
@@ -37,7 +37,7 @@
namespace Gendarme.Rules.Smells {
- internal class CodeDuplicatedLocator {
+ internal sealed class CodeDuplicatedLocator {
private StringCollection methods = new StringCollection ();
private StringCollection types = new StringCollection ();
Modified: trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/Expression.cs
===================================================================
--- trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/Expression.cs
2008-02-07 17:20:33 UTC (rev 95158)
+++ trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/Expression.cs
2008-02-07 17:20:33 UTC (rev 95159)
@@ -37,7 +37,7 @@
namespace Gendarme.Rules.Smells {
- internal class Expression : CollectionBase {
+ internal sealed class Expression : CollectionBase {
public Expression () : base () {}
Modified:
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/ExpressionFillerVisitor.cs
===================================================================
---
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/ExpressionFillerVisitor.cs
2008-02-07 17:20:33 UTC (rev 95158)
+++
trunk/mono-tools/gendarme/rules/Gendarme.Rules.Smells/ExpressionFillerVisitor.cs
2008-02-07 17:20:33 UTC (rev 95159)
@@ -33,7 +33,7 @@
namespace Gendarme.Rules.Smells {
- internal class ExpressionFillerVisitor : BaseCodeVisitor {
+ internal sealed class ExpressionFillerVisitor : BaseCodeVisitor {
private IList expressionContainer;
private Expression currentExpression;
_______________________________________________
Mono-patches maillist - [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches
