Author: spouliot
Date: 2008-02-07 14:46:09 -0500 (Thu, 07 Feb 2008)
New Revision: 95184

Modified:
   trunk/moon/src/ChangeLog
   trunk/moon/src/shape.cpp
Log:
2008-02-07  Sebastien Pouliot  <[EMAIL PROTECTED]>

        * shape.cpp: Add comment about (missing) Path::ComputeLargestRectangle



Modified: trunk/moon/src/ChangeLog
===================================================================
--- trunk/moon/src/ChangeLog    2008-02-07 19:40:50 UTC (rev 95183)
+++ trunk/moon/src/ChangeLog    2008-02-07 19:46:09 UTC (rev 95184)
@@ -1,3 +1,7 @@
+2008-02-07  Sebastien Pouliot  <[EMAIL PROTECTED]>
+
+       * shape.cpp: Add comment about (missing) Path::ComputeLargestRectangle
+
 2008-02-07  Larry Ewing  <[EMAIL PROTECTED]>
 
        * shape.cpp: cache the results of CompouteShapeBounds in

Modified: trunk/moon/src/shape.cpp
===================================================================
--- trunk/moon/src/shape.cpp    2008-02-07 19:40:50 UTC (rev 95183)
+++ trunk/moon/src/shape.cpp    2008-02-07 19:46:09 UTC (rev 95184)
@@ -2089,6 +2089,15 @@
                Shape::OnSubPropertyChanged (prop, obj, subprop);
 }
 
+/*
+ * Right now implementing Path::ComputeLargestRectangle doesn't seems like a 
good idea. That would require
+ * - checking the path for curves (and either flatten it or return an empty 
Rect)
+ * - checking for polygon simplicity (finding intersections)
+ * - checking for a convex polygon (if concave we can turn it into several 
convex or return an empty Rect)
+ * - find the largest rectangle inside the (or each) convex polygon(s)
+ *     
http://cgm.cs.mcgill.ca/~athens/cs507/Projects/2003/DanielSud/complete.html
+ */
+
 Geometry *
 path_get_data (Path *path)
 {

_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches

Reply via email to