1. adding some comments :-) 2. this library is for calculating the lengths of ttf strings. It works okay, but is slow, because it reads and reads parts of the ttf file in every call. This needs optimiziation (effectively, a cache in a bottleneck), which I already did, only want to upload.
Thanks, Akos -----Ursprüngliche Nachricht----- Von: Matt S Trout [mailto:m...@shadowcat.co.uk] Gesendet: Mittwoch, 11. April 2012 18:48 An: Malay Basu Cc: Horvath, Akos; modu...@cpan.org; ma...@bioinformatics.org Betreff: Re: warning: false alarm, possible bug in Font::TTFMetrics On Wed, Apr 11, 2012 at 12:43:20PM -0400, Malay Basu wrote: > Thanks Matt, > > I don't know what Akos is talking about. There is no unchecked eval in > the code. The only eval is to check that the input file is readable. > If the read call fails then the modules exits gracefully. There is > *no* problem with this eval. Oh. I see Akos forgot to show us the next line where it actually checks the exception. Ooops :) Even so, he clearly does care. Perhaps you should get Akos to add comments to make the code more clear so nobody gets confused like this again? Akos, would that be something you might enjoy doing? -- Matt S Trout - Shadowcat Systems - Perl consulting with a commit bit and a clue http://shadowcat.co.uk/blog/matt-s-trout/ http://twitter.com/shadowcat_mst/ Email me now on mst (at) shadowcat.co.uk and let's chat about how our Catalyst commercial support, training and consultancy packages could help your team.
