Fwd: A patch suggestion for UDPM.pm version 0.88

[Jess Portnoy]

Hello Admins,

The mail I sent to Kevin C. Krinke bounced.
I'd like to maintain it, if possible.

Regards,

---------- Forwarded message ----------
From: Jess Portnoy <kerne...@gmail.com>
Date: Sat, Feb 26, 2011 at 8:47 PM
Subject: A patch suggestion for UDPM.pm version 0.88
To: kckri...@opendoorsoftware.com


Hello Kevin,

First, let me say I like this Perl module very much.
I'm attaching a diff file with a patch suggestion.

Also, I've noticed the last release for this module was on 09 May 2003, do
you no longer maintain it? If not, I might be interested in maintaining or
co-maintaining it.

Let me know if relevant.
-- 
Use Linux - Live longer
Best regards,

Jess Portnoy



-- 
Use Linux - Live longer
Best regards,

Jess Portnoy

--- /usr/local/share/perl/5.10.0/UDPM.pm	2003-05-04 10:12:14.000000000 +0300
+++ /tmp/UDPM_jess.pm	2011-02-26 20:36:37.000000000 +0200
@@ -206,7 +206,7 @@
   my $self = shift();
   my $bn = basename($self->{'dialog'});
   if ($self->{'ascii'}) { return("ascii"); }
# added $bn eq 'kdialog'
-  elsif ($bn eq "whiptail" || $bn eq "gdialog" || $bn eq "ascii") { return($bn); }
+  elsif ($bn eq "whiptail" || $bn eq "gdialog" || $bn eq "ascii" || $bn eq 'kdialog') { return($bn); }
   elsif ($bn eq "dialog") {
     my $str = `$self->{'dialog'} --help 2>&1`;
     if ($str =~ /cdialog\s\(ComeOn\sDialog\!\)\sversion\s(\d+\.\d+.+)/) {
@@ -231,6 +231,7 @@
   } else {
     if ($self->{'dialogbin'} && -x $self->{'dialogbin'}) {
       $self->{'dialog'} = $self->{'dialogbin'};
# since we got a $self->{'dialogbin'} passed to new() why not set it here and skip the call to __TEST_VARIANT()? Although, one could argue that in the future __TEST_VARIANT() may do more than just return basename $self->{'dialogbin'}, an argument that has some point to it :) 
+    	$self->{'dialogtype'} = basename $self->{'dialogbin'};
     } else {
       my @paths;
       if ($ENV{'PATH'}) { @paths = split(/:/,$ENV{'PATH'}); }
@@ -240,8 +241,8 @@
 	last WDCHECK unless !$self->{'dialog'};
       }
       $self->{'dialog'} = "ascii" unless -x $self->{'dialog'};
+    	$self->{'dialogtype'} = $self->__TEST_VARIANT();
     }
-    $self->{'dialogtype'} = $self->__TEST_VARIANT();
     $self->{'ascii'} = 1 if $self->{'dialogtype'} eq "ascii";
     if ($ENV{'DISPLAY'} && ($self->is_gdialog() || $self->is_kdialog()) && !$self->{'ascii'}) { $self->{'gui'} = 1; }
     else { $self->{'gui'} = 0; }