On Tue, Sep 04, 2012 at 02:40:01PM +0100, Martin J. Evans wrote:
> I recently received an rt (https://rt.cpan.org/Ticket/Display.html?id=79190)
> saying some code in DBD::ODBC was wrong and a patch to fix it. The code was:
>
> while (*cp != '\0') {
> *cp++ = toupper(*cp);
> }
>
> and the fix (which shouldn't be required as the above code is fine) was:
I don't think your code is fine. = isn't a sequence point.
> while (*cp != '\0') {
> *cp = toupper(*cp);
> cp++;
> }
And this seems to be a correct fix.
--
Paul Johnson - p...@pjcj.net
http://www.pjcj.net
