Philip M. Gollucci <[EMAIL PROTECTED]> wrote: > sub handler { > my $r = shift; > > my $user = ISST::User->getLoggedIn($r); > > ## IS THIS CORRECT ? > ## can't used DECLINED or you get the REALM popup > return Apache2::Const::OK if $r->uri =~ > m#/timeline/(login|logout|register|privacy)#;
That looks great to me. If getLoggedIn() doesn't have any side effects (such as setting $r->user), you could also make it a tiny tiny bit faster by removing the "my $user" line above, and changing this: > > if ($user) { > return Apache2::Const::OK; To: if(ISST::User->getLoggedIn($r)) { return Apache2::Const::OK; Cheers, Tyler