Dorian Taylor wrote:
Using Debian testing with the packaged versions of Apache 2.0.54-prefork
and APR 0.9.6, I ran make source_scan on the -current (rc6) tarball.
It seems that only the constant groups fopen, fprot and filetype
were found. I can only presume after looking at Apache2::ParseSource,
that the required apr headers are never seen.

Right, since all those who need to run source_scan install apache manually with a default destination, so all headers end up in the apache dir.


I added the following which seemed to clear it up:

--- ../mod_perl-2.0.0-RC5/lib/Apache2/ParseSource.pm    2005-04-14 
05:19:34.000000000 -0700
+++ lib/Apache2/ParseSource.pm  2005-05-09 10:00:08.000000000 -0700
@@ -115,6 +115,8 @@
 sub include_dirs {
     my $self = shift;
     ($self->config->apxs('-q' => 'INCLUDEDIR'),
+    $self->config->apxs('-q' => 'APR_INCLUDEDIR'),
+    $self->config->apxs('-q' => 'APU_INCLUDEDIR'),
      $self->config->mp_include_dir);
 }

i'm currently running a make test (which seems to pass minus
content_length_header.t, but that's another issue).

It breaks the case where all headers are in the Apache dir, since it introduces dups iin the headers. I'd gladly commit a patch which also ensures that there are no dups. Unfortunately the scan process is a way too fragile.


--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Reply via email to