Haroon Rafique wrote:
Hi,

Currently, Apache::DBI's connect_on_init method requires that Apache::compat be loaded or it carps "Apache.pm was not loaded" and returns.

Find attached a patch for Apache::DBI which gets rid of the dependency for Apache::compat. While in the process, I also fixed a second TODO in sub connect related to mod_perl. I don't know if the call to Apache::Status->menu_item() near __END__ will work as is. Probably not.

Comments are most welcome. I'm sure it needs more work, and that's why we have more than one contributors. Are you out there Ask :-) ?
[...]
-    if([EMAIL PROTECTED] and Apache->can('push_handlers')) {
-        Apache->push_handlers(PerlChildInitHandler => \&childinit);
+    if([EMAIL PROTECTED] and (MP2 ? 1 : Apache->can('push_handlers'))) {
+        if( MP2 ) {
+            Apache->server->push_handlers(PerlChildInitHandler => \&childinit);
+        } else {
+            Apache->push_handlers(PerlChildInitHandler => \&childinit);

I think here and below you don't need to do this branching. since the C function mod_perl_push_handlers ignores the first argument, Apache->server->push_handlers() should work just fine under mp1, but I didn't test it.


--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

--
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html



Reply via email to