Geoffrey Young wrote: [...]
I just missed the content-length header on HEAD requests that is delivered on GET.
Geoff, see the t/apache/head_request.t test I've added last night. If you don't send a body, Apache strips the C-L header for HEAD requests. Sending at least 1 byte works as a workaround, but it smells like a bug in Apache.
yes, clearly there is a bug in there, but not where you think - what is important is that apache needs to do the same thing on GET as HEAD, not that there is no C-L generated for contentless HEAD requests. this patch more accurately represents the real bug which, IIRC, httpd is already aware of (at least I'm recalling discussion about a C-L of 0).
Why do you say so? Your patch respresents a related, but a different issue. Boris has a problem with HEAD, and that's what the test was testing.
But, certainly please commit it, rename the files to something different (content_length_header.t?) since it's not longer a HEAD request. And please add a comment explaining the bug, ideally with xref to a bugzilla for the bug you are talking about or discussion thread.
Thanks.
also please move that no strict thing, inside the block, where it is needed. Thanks.
+no strict qw(refs);
+foreach my $method qw(GET HEAD) {
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
-- Report problems: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html List etiquette: http://perl.apache.org/maillist/email-etiquette.html
