On Sun, Jan 11, 2004 at 12:36:33PM -0800, Stas Bekman wrote:
> Jay R. Ashworth wrote:
> > Thank ghod for tgrep. TMPDIR falls back to /tmp, and mine, probably
> > because of a drive failure and subsequent unmounting, was 755 instead
> > of 777; I presume that the comment above should actually be "the user
> > your apache runs as"?
>
> Yes, you are correct.
>
> > Tested fine this time.
>
> Perfect.
>
> > Glenn's right; that should be tested explicitly.
>
> Not sure what you are reffering to (I haven't seen any messages from Glen on
> the list), but here is the patch that I've just committed:
Apologies to both; "Geoffrey's right..."
> Index: lib/Apache/compat.pm
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/lib/Apache/compat.pm,v
> retrieving revision 1.94
> diff -u -r1.94 compat.pm
> --- lib/Apache/compat.pm 20 Dec 2003 01:28:43 -0000 1.94
> +++ lib/Apache/compat.pm 11 Jan 2004 20:21:35 -0000
> @@ -589,7 +589,8 @@
> my $tmpfile = "$TMPDIR/${$}" . $TMPNAM++;
> my $fh = $class->new;
>
> - sysopen($fh, $tmpfile, $Mode, $Perms);
> + sysopen $fh, $tmpfile, $Mode, $Perms
> + or die "failed to open $tmpfile: $!";
> $r->pool->cleanup_register(sub { unlink $tmpfile });
>
> if ($fh) {
If I weren't so busy trying to get WebGUI to run overtop it (the
upgrade of mp2 didn't fix my problem), I'd observe that there are
probably lots of other sysopens in the scaffold that ought to be checked
for error handling... but a) I'd probably be encouraged to generate
patches (:-) and b) I'm probably worng.
Cheers,
-- jra
--
Jay R. Ashworth [EMAIL PROTECTED]
Member of the Technical Staff Baylink RFC 2100
The Suncoast Freenet The Things I Think
Tampa Bay, Florida http://baylink.pitas.com +1 727 647 1274
Come see Linux Gazette in our new home: www.linuxgazette.net!
--
Reporting bugs: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
