Randy Kobes wrote:
On Thu, 27 Nov 2003, Stas Bekman wrote:


Randy Kobes wrote:
[...]

I think it is a ModPerl::BuildMM thing - this patch

[ .. ]


arranges for everything to be put under an Apache2/.

Cool. Though, it's probably easier to read:


$v =~ s{(blib([/\\])lib)}{$1$2Apache2};

or even:

$v =~ s{ (blib[/\\]lib) }{ catdir $1, 'Apache2'}xe;

I thought there is at least one more variation of the dir
separator, wasn't it ':'?


Good point - how about
===========================================================
Index: lib/ModPerl/BuildMM.pm

+1, though probably also drop the () as they aren't needed now that File::Spec imports the functions.


-my $apache_test_dir = File::Spec->catdir(Cwd::getcwd(), "Apache-Test", "lib");
+my $apache_test_dir = catdir Cwd::getcwd(), "Apache-Test", "lib";

etc... to be consistent with the rest of the code.

--


__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com


-- Reporting bugs: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html



Reply via email to