John Peacock wrote:
Stas Bekman wrote:


Yup, I know, Carl has reported this earlier, but never followed up on my suggestion. Please try this patch:


Excellent! That gets it building and all the tests pass!

Good, but it's not the real fix, can you please revert that patch and try a new patch at the end of this file? Thanks.


because the -Wl is the cc option that should have been stripped before passing the -E to ld. :~(



Yup, that's a known issue, caused by a recent change in MakeMaker and fixed in the mp2 cvs. You can probably fix it in 1.99_09 with this patch:
http://marc.theaimsgroup.com/?l=apache-modperl-cvs&m=106390946300985&w=2



and that fixes the other problem. Please doing business with you sir! ;~)

That was Geoff's fix ;)


--------------------------------------

Index: src/modules/perl/modperl_callback.c
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_callback.c,v
retrieving revision 1.58
diff -u -r1.58 modperl_callback.c
--- src/modules/perl/modperl_callback.c 18 Sep 2003 07:46:26 -0000      1.58
+++ src/modules/perl/modperl_callback.c 23 Sep 2003 19:17:22 -0000
@@ -268,9 +268,7 @@
     SvREFCNT_dec((SV*)av_args);

     /* PerlInterpScope handler */
-#ifdef USE_ITHREADS
-    MP_dINTERP_PUTBACK(interp);
-#endif
+    MP_INTERP_PUTBACK(interp);

     return status;
 }
Index: src/modules/perl/modperl_filter.c
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_filter.c,v
retrieving revision 1.68
diff -u -r1.68 modperl_filter.c
--- src/modules/perl/modperl_filter.c   18 Sep 2003 07:34:21 -0000      1.68
+++ src/modules/perl/modperl_filter.c   23 Sep 2003 19:17:22 -0000
@@ -360,7 +360,7 @@

SvREFCNT_dec((SV*)args);

-    MP_dINTERP_PUTBACK(interp);
+    MP_INTERP_PUTBACK(interp);

     MP_TRACE_f(MP_FUNC, MP_FILTER_NAME_FORMAT
                "return: %d\n", handler->name, status);
@@ -432,7 +432,7 @@
         MP_FAILURE_CROAK(modperl_output_filter_flush(filter));
     }

-    MP_dINTERP_PUTBACK(interp);
+    MP_INTERP_PUTBACK(interp);

     MP_TRACE_f(MP_FUNC, MP_FILTER_NAME_FORMAT
                "return: %d\n", handler->name, status);
Index: src/modules/perl/modperl_interp.h
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_interp.h,v
retrieving revision 1.19
diff -u -r1.19 modperl_interp.h
--- src/modules/perl/modperl_interp.h   13 Sep 2003 20:35:33 -0000      1.19
+++ src/modules/perl/modperl_interp.h   23 Sep 2003 19:17:22 -0000
@@ -50,7 +50,7 @@
     interp = modperl_interp_select(r, c, s); \
     aTHX = interp->perl

-#define MP_dINTERP_PUTBACK(interp) \
+#define MP_INTERP_PUTBACK(interp) \
     if (interp && MpInterpPUTBACK(interp)) { \
         modperl_interp_unselect(interp); \
     }
@@ -77,7 +77,7 @@

#define MP_dINTERP_SELECT(r, c, s) dNOOP

-#define MP_dINTERP_PUTBACK(interp) dNOOP
+#define MP_INTERP_PUTBACK(interp) NOOP

#define MP_aTHX 0




__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com



Reply via email to