Yes, definitely!
-----Original Message-----
From: Aleksander Morgado <aleksan...@aleksander.es>
Sent: Thursday, 28 April 2022 1:46 PM
To: Amol Lad <amol....@4rf.com>
Cc: ModemManager (development) <modemmanager-devel@lists.freedesktop.org>
Subject: Re: messaging-list-sms issue
Hey!
>
> There seems a small issue in "mmcli -m 0 --messaging-list-sms -K" reporting
> (in MM 1.18.6). When the number of SMS is >= 100 then closing square bracket
> for the message index is missing in the output as shown below (see index 100
> and above, closing square bracket is missing). Please advise how this can be
> addressed.
>
Ouch! please open a new Issue in gitlab to track this problem.
The problem is in dump_output_list_keyvalue(), where this logic exists:
if (n > 0) {
key_length += ((strlen (KEY_ARRAY_VALUE_SUFFIX)) + 3);
if (n > 10)
key_length++;
}
That is extremely buggy, whoever wrote that should be punished! :)
Instead of checking for n > 10, it should have done something like:
while ((aux /= 10) > 0)
key_length++;
If you're up to fixing and testing that, please open a MR :)
--
Aleksander
https://aleksander.es
