Hey, > > Thanks for reminding me. I had been playing with the > --enable-collection=$COLLECTION flag, nevertheless I did have full selected, > so I may have messed something up in the makefile. Rebuilding without any of > this in the makefile resulted in the standard working build. > > Anyway, that flag just needs to be added to the CONFIGURE_ARGS, right? >
Yes. > Here is what I had - > > > define Package/libqmi/config > source "$(SOURCE)/Config.in” > endef > ... > ifdef CONFIG_LIBQMI_COLLECTIONS_MINIMAL > CONFIGURE_ARGS += --enable-collection=minimal > endif > > ifdef CONFIG_LIBQMI_COLLECTIONS_BASIC > CONFIGURE_ARGS += --enable-collection=basic > endif > > ifdef CONFIG_LIBQMI_COLLECTIONS_FULL > CONFIGURE_ARGS += --enable-collection=full > endif > … > > and in Config.in. After my experience I am thinking it would be best to make > FULL the default. > > menu "Configuration" > depends on PACKAGE_libqmi > > config LIBQMI_COLLECTIONS_MINIMAL > bool "Build with minimal message collection support" > default n > help > the bare minimum messages required to control connectivity > > config LIBQMI_COLLECTIONS_BASIC > bool "Build with basic message collection support" > default y > help > all messages and indications that ModemManager requires > > config LIBQMI_COLLECTIONS_FULL > bool "Build with full message collection support" > default n > help > all supported messages and indications > endmenu > FULL is already the default if you don't specify anything in the configure, and if you don't want a ton of angry users, I would also make FULL the default in the OpenWRT packaging setup ;) -- Aleksander https://aleksander.es _______________________________________________ ModemManager-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
