On Fri, Nov 15, 2019 at 1:41 PM Amol Lad <amol....@4rf.com> wrote: > > I'll test it straight away but before that, is similar change needed in > proto_modemmanager_teardown () as well? >
Yep yep, you're right, I've updated the patch: https://github.com/aleksander0m/openwrt-packages/commit/50264dfbd1b365d4639a89085345dd7578021dc9 > proto_modemmanager_teardown() { > local interface="$1" > > local modemstatus bearerpath errorstring > local bearermethod_ipv4 bearermethod_ipv6 > > local device lowpower iptype > json_get_vars device lowpower iptype > > echo "stopping network" > > # load connected bearer information, just the first one should be ok > modemstatus=$(mmcli --modem="${device}" --output-keyvalue) > bearerpath=$(modemmanager_get_field "${modemstatus}" > "modem.generic.bearers.value\[1\]") > [ -n "${bearerpath}" ] || { > echo "couldn't load bearer path" > return > } > > # ip type IPv4 is assumed if none explicitly given > [ -z "${iptype}" ] && iptype="ipv4" > > # load bearer connection methods > bearerstatus=$(mmcli --bearer "${bearerpath}" --output-keyvalue) > [ "$iptype" = "ipv4" ] || [ "$iptype" = "ipv4v6" ] && { > bearermethod_ipv4=$(modemmanager_get_field "${bearerstatus}" > "bearer.ipv4-config.method") > echo "IPv4 connection teardown required in interface ${interface}: > ${bearermethod_ipv4}" > } > [ "$iptype" = "ipv6" ] || [ "$iptype" = "ipv4v6" ] && { > bearermethod_ipv6=$(modemmanager_get_field "${bearerstatus}" > "bearer.ipv6-config.method") > echo "IPv6 connection teardown required in interface ${interface}: > ${bearermethod_ipv6}" > } > > > The information in this email communication (inclusive of attachments) is > confidential to 4RF Limited and the intended recipient(s). If you are not the > intended recipient(s), please note that any use, disclosure, distribution or > copying of this information or any part thereof is strictly prohibited and > that the author accepts no liability for the consequences of any action taken > on the basis of the information provided. If you have received this email in > error, please notify the sender immediately by return email and then delete > all instances of this email from your system. 4RF Limited will not accept > responsibility for any consequences associated with the use of this email > (including, but not limited to, damages sustained as a result of any viruses > and/or any action or lack of action taken in reliance on it).-----Original > Message----- > From: Aleksander Morgado <aleksan...@aleksander.es> > Sent: Friday, 15 November 2019 6:04 PM > To: Amol Lad <amol....@4rf.com> > Cc: modemmanager-devel@lists.freedesktop.org > Subject: Re: MM_BEARER_IP_FAMILY_ANY broken in MM 1.12.0? > > > > > Please find logs for mm in debug mode for iptype set to "ipv4" and > > > > "any" separately > > > > > > > > > > Ah, I know what the issue is. The "any" ip-type case is not being > > > handled in the modemmanager.proto file in the openwrt package, so as > > > soon as the modem gets connected, it just fails. Let me fix that. > > > > > > > Could you please retest with this patch applied? > > https://github.com/aleksander0m/openwrt-packages/commit/045fd921c15331 > > 637d1ec874fe1dc61fac7e8403 > > > > Sorry, forgot to update package version, please try this one: > https://github.com/aleksander0m/openwrt-packages/commit/fbf60bdd2d5ebc4eeeaee1d690299c2530a9cc12 > > -- > Aleksander > https://aleksander.es -- Aleksander https://aleksander.es _______________________________________________ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
