Hey all, we are now running findbugs[1] in automation (tier-2). After fixing a bug that should have been caught by a code analyzer tool (and was missed in review) this seemed worth doing.
If findbugs warns about new code then the automation task will fail and print a report. And you can run it locally too: mach gradle app:findbugsLocalDebug Currently we only check for "high" priority warnings. This is mostly because we have a ton of medium and low warnings that need to be fixed first. We also had a bunch of "high" warnings and almost all of them have been fixed by our awesome volunteers (I filed all of them as mentor bugs). But we still exclude some checks until we have fixed all the remaining warnings: https://dxr.mozilla.org/mozilla-central/source/mobile/android/app/findbugs-exclude.xml Want to know more? * Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=findbugs-android * Here's a try run with findbugs: https://mzl.la/2fRrcQB * A report with warnings: https://public-artifacts.taskcluster.net/QGgxPWiAQUOH47MVopQNfw/0/public/android/findbugs/findbugs-report.html Sebastian [1] http://findbugs.sourceforge.net/
_______________________________________________ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org https://mail.mozilla.org/listinfo/mobile-firefox-dev
