On Sun, Apr 11, 2010 at 8:47 AM, Michael Small <sma...@panix.com> wrote: > where my wi wireless card stopped working on my old latitude. I noticed > an ansification of functions in pccbb.c happening (revision 164) that > claimed to make no binary change but actually changed the signature of > pccbb_pcmcia_write from > > > void > pccbb_pcmcia_write(ph, reg, val) > struct pcic_handle *ph; > int reg; > u_int8_t val; > > ... to ... > > void > pccbb_pcmcia_write(struct pcic_handle *ph, int reg, int val) > > Curiously, there was a fn prototype in the 4.5 version that also had val > be int, conflicting with the definition, which makes it almost like his > case, except it was all within one file.
The calling convention for old function declarations is to promote smaller than int types to int. So that change was actually equivalent. It also didn't conflict with the prototype, which was correct for how the function was expecting its arguments.
