replying in public, since there are at least two people hacking on that * Konrad <[EMAIL PROTECTED]> [2008-03-06 10:26]: > So sorry its not a propper diff anymore but this is what i've done:
unfortunatly this is not enough. it messes the refcounting. the tagname2tag routing keeps a refcount for the name<->tag-id mapping and removes it when the refcount drops to zero. pf_tagname2tag increases that refcount. you must call pf_tag_unref() at some point to decrease it again. this can be slightly nasty with sockets... some cases to consider: -of course, we need to unref when the socket is destroyed. -when we set a tag, and there was already a tag set on the socket, we need to do the unref for the old one. -what happens on accept()? also, as you already mentioned, the non-tcp cases are missing yet. but this is a nice start, keep going! -- Henning Brauer, [EMAIL PROTECTED], [EMAIL PROTECTED] BS Web Services, http://bsws.de Full-Service ISP - Secure Hosting, Mail and DNS Services Dedicated Servers, Rootservers, Application Hosting - Hamburg & Amsterdam
