On Thu, Feb 22, 2024 at 03:28:42PM +0100, Marco van Hulten wrote:
> On Thu, 22 Feb 2024 13:29:27 +0100 Stefan Sperling wrote:
> > Can you reproduce this on non-WPA-Enterprise networks,
> > i.e. without eduraom / wpaakms 802.1x?
>
> Did not succeed in reproducing so far.
I figured out the scan command error, details and patch below.
The good news is that this is just a cosmetic issue.
Let me know if you still see any issues with the patch applied.
> Additional dmesg output that seems to be new:
>
> qwx0: missed beacon threshold set to 30 beacons, beacon interval is 100 TU
> qwx0: failed to enqueue rx buf: 28
> qwx_ce_recv_process_cb: failed to post rx buf to pipe: 2 err: 28
The above is a known issue I still need to investigate.
I suspect it is harmless.
Now, regarding your scan command failures:
An important detail is that ifconfig will make multiple calls into
the kernel while reconfiguring the interface:
ifconfig qwx0 nwid eduroam wpa wpaakms 802.1x up
This command enters the driver in the kernel 4 times in a row:
nwid eduroam # 1) set network ID
wpa # 2) enable WPA
wpaakms 802.1x # 3) enable WPA Enterprise
up # 4) set UP flag
Every time the driver is entered, a configuration change is flagged
(by signalling error ENETRESET internally) which causes the driver
to stop and restart the interface to let the configuration change take
effect. Provided the interface is already marked UP, the final step
of restarting a wifi device is to begin a scan for APs.
This scan runs in a separate background thread in the kernel and the
ifconfig process will continue running "in parallel" to the scan.
ifonfig will more or less immediately enter the kernel again to
apply the next configuration item (e.g. in step 2 to enable WPA).
Now the driver wants to stop the interface again, but the scan thread
is still active!
We don't want the device to see a confusing mix of commands coming from
multiple threads, so the driver needs to wait for the scan thread to
finish before it can proceed to stop and restart the device again.
The ifconfig driver thread sets a global "please stop" flag and waits...
Before the scan thread sends its scan command it will check the "please stop"
flag. When it is set, the Linux code we inherited returns ESHUTDOWN, which
is error number 58. This matches the error you are seeing:
qwx0: failed to start hw scan: 58
So this is not an actual error condition, it is expected behaviour.
ESHUTDOWN will cause the scan thread to stop what is it doing and
allow the ifconfig driver thread to take back control of the hardware.
The patch below should avoid printing a warning about this for all
WMI commands, including your case, but handling other potential
cases as well.
-----------------------------------------------
make qwx(4) ignore ESHUTDOWN while printing errors to dmesg
ESHUTDOWN is an expected thread-synchronization condition which
can be triggered via ifconfig commands. Don't warn about this.
Reported by Marco van Hulten on misc@
diff 11a0e80d7bc8830d3a9189682bad3c13b0eeb2cb
9d7e156a181573d2b75a72c9297a5ec5796865f7
commit - 11a0e80d7bc8830d3a9189682bad3c13b0eeb2cb
commit + 9d7e156a181573d2b75a72c9297a5ec5796865f7
blob - 43753d3d31405116391a7f706fb0735162b062b5
blob + f0ad77d417bb8774b7de90c543705bd9bbec57a9
--- sys/dev/ic/qwx.c
+++ sys/dev/ic/qwx.c
@@ -17232,8 +17232,10 @@ qwx_wmi_pdev_set_param(struct qwx_softc *sc, uint32_t
ret = qwx_wmi_cmd_send(wmi, m, WMI_PDEV_SET_PARAM_CMDID);
if (ret) {
- printf("%s: failed to send WMI_PDEV_SET_PARAM cmd\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send WMI_PDEV_SET_PARAM cmd\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -17268,8 +17270,10 @@ qwx_wmi_pdev_lro_cfg(struct qwx_softc *sc, uint8_t pde
ret = qwx_wmi_cmd_send(wmi, m, WMI_LRO_CONFIG_CMDID);
if (ret) {
- printf("%s: failed to send lro cfg req wmi cmd\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send lro cfg req wmi cmd\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -17303,8 +17307,10 @@ qwx_wmi_pdev_set_ps_mode(struct qwx_softc *sc, int vde
ret = qwx_wmi_cmd_send(wmi, m, WMI_STA_POWERSAVE_MODE_CMDID);
if (ret) {
- printf("%s: failed to send WMI_PDEV_SET_PARAM cmd\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send WMI_PDEV_SET_PARAM cmd\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -17345,8 +17351,10 @@ qwx_wmi_scan_prob_req_oui(struct qwx_softc *sc, const
ret = qwx_wmi_cmd_send(wmi, m, WMI_SCAN_PROB_REQ_OUI_CMDID);
if (ret) {
- printf("%s: failed to send WMI_SCAN_PROB_REQ_OUI cmd\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send WMI_SCAN_PROB_REQ_OUI cmd\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -17378,8 +17386,11 @@ qwx_wmi_send_dfs_phyerr_offload_enable_cmd(struct qwx_
ret = qwx_wmi_cmd_send(wmi, m,
WMI_PDEV_DFS_PHYERR_OFFLOAD_ENABLE_CMDID);
if (ret) {
- printf("%s: failed to send WMI_PDEV_DFS_PHYERR_OFFLOAD_ENABLE "
- "cmd\n", sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send "
+ "WMI_PDEV_DFS_PHYERR_OFFLOAD_ENABLE cmd\n",
+ sc->sc_dev.dv_xname);
+ }
m_free(m);
return ret;
}
@@ -17504,8 +17515,10 @@ qwx_wmi_send_scan_chan_list_cmd(struct qwx_softc *sc,
ret = qwx_wmi_cmd_send(wmi, m, WMI_SCAN_CHAN_LIST_CMDID);
if (ret) {
- printf("%s: failed to send WMI_SCAN_CHAN_LIST cmd\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send WMI_SCAN_CHAN_LIST "
+ "cmd\n", sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -17543,8 +17556,10 @@ qwx_wmi_send_11d_scan_start_cmd(struct qwx_softc *sc,
ret = qwx_wmi_cmd_send(wmi, m, WMI_11D_SCAN_START_CMDID);
if (ret) {
- printf("%s: failed to send WMI_11D_SCAN_START_CMDID: %d\n",
- sc->sc_dev.dv_xname, ret);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send WMI_11D_SCAN_START_CMDID: "
+ "%d\n", sc->sc_dev.dv_xname, ret);
+ }
m_freem(m);
return ret;
}
@@ -17819,8 +17834,10 @@ qwx_wmi_send_scan_start_cmd(struct qwx_softc *sc,
ret = qwx_wmi_cmd_send(wmi, m, WMI_START_SCAN_CMDID);
if (ret) {
- printf("%s: failed to send WMI_START_SCAN_CMDID\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send WMI_START_SCAN_CMDID\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -17872,8 +17889,10 @@ qwx_wmi_send_scan_stop_cmd(struct qwx_softc *sc,
ret = qwx_wmi_cmd_send(wmi, m, WMI_STOP_SCAN_CMDID);
if (ret) {
- printf("%s: failed to send WMI_STOP_SCAN_CMDID\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send WMI_STOP_SCAN_CMDID\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -17906,8 +17925,10 @@ qwx_wmi_send_peer_create_cmd(struct qwx_softc *sc, uin
ret = qwx_wmi_cmd_send(wmi, m, WMI_PEER_CREATE_CMDID);
if (ret) {
- printf("%s: failed to submit WMI_PEER_CREATE cmd\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to submit WMI_PEER_CREATE cmd\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -17941,8 +17962,10 @@ qwx_wmi_send_peer_delete_cmd(struct qwx_softc *sc, con
ret = qwx_wmi_cmd_send(wmi, m, WMI_PEER_DELETE_CMDID);
if (ret) {
- printf("%s: failed to send WMI_PEER_DELETE cmd\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send WMI_PEER_DELETE cmd\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -18176,8 +18199,10 @@ qwx_wmi_send_peer_assoc_cmd(struct qwx_softc *sc, uint
ret = qwx_wmi_cmd_send(wmi, m, WMI_PEER_ASSOC_CMDID);
if (ret) {
- printf("%s: failed to send WMI_PEER_ASSOC_CMDID\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send WMI_PEER_ASSOC_CMDID\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -18379,7 +18404,8 @@ qwx_init_cmd_send(struct qwx_pdev_wmi *wmi, struct wmi
ret = qwx_wmi_cmd_send(wmi, m, WMI_INIT_CMDID);
if (ret) {
- printf("%s: failed to send WMI_INIT_CMDID\n", __func__);
+ if (ret != ESHUTDOWN)
+ printf("%s: failed to send WMI_INIT_CMDID\n", __func__);
m_freem(m);
return ret;
}
@@ -18462,8 +18488,10 @@ qwx_wmi_set_hw_mode(struct qwx_softc *sc,
ret = qwx_wmi_cmd_send(&wmi->wmi[0], m, WMI_PDEV_SET_HW_MODE_CMDID);
if (ret) {
- printf("%s: failed to send WMI_PDEV_SET_HW_MODE_CMDID\n",
- __func__);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send "
+ "WMI_PDEV_SET_HW_MODE_CMDID\n", __func__);
+ }
m_freem(m);
return ret;
}
@@ -18499,8 +18527,11 @@ qwx_wmi_set_sta_ps_param(struct qwx_softc *sc, uint32_
ret = qwx_wmi_cmd_send(wmi, m, WMI_STA_POWERSAVE_PARAM_CMDID);
if (ret) {
- printf("%s: failed to send WMI_STA_POWERSAVE_PARAM_CMDID",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send "
+ "WMI_STA_POWERSAVE_PARAM_CMDID",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -18559,8 +18590,11 @@ qwx_wmi_mgmt_send(struct qwx_softc *sc, struct qwx_vif
#endif
ret = qwx_wmi_cmd_send(wmi, m, WMI_MGMT_TX_SEND_CMDID);
if (ret) {
- printf("%s: failed to submit WMI_MGMT_TX_SEND_CMDID cmd\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to submit "
+ "WMI_MGMT_TX_SEND_CMDID cmd\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -18638,8 +18672,10 @@ qwx_wmi_vdev_create(struct qwx_softc *sc, uint8_t *mac
ret = qwx_wmi_cmd_send(wmi, m, WMI_VDEV_CREATE_CMDID);
if (ret) {
- printf("%s: failed to submit WMI_VDEV_CREATE_CMDID\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to submit WMI_VDEV_CREATE_CMDID\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -18675,8 +18711,10 @@ qwx_wmi_vdev_set_param_cmd(struct qwx_softc *sc, uint3
ret = qwx_wmi_cmd_send(wmi, m, WMI_VDEV_SET_PARAM_CMDID);
if (ret) {
- printf("%s: failed to send WMI_VDEV_SET_PARAM_CMDID\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send WMI_VDEV_SET_PARAM_CMDID\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -18729,8 +18767,10 @@ qwx_wmi_vdev_up(struct qwx_softc *sc, uint32_t vdev_id
#endif
ret = qwx_wmi_cmd_send(wmi, m, WMI_VDEV_UP_CMDID);
if (ret) {
- printf("%s: failed to submit WMI_VDEV_UP cmd\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to submit WMI_VDEV_UP cmd\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -18762,8 +18802,10 @@ qwx_wmi_vdev_down(struct qwx_softc *sc, uint32_t vdev_
ret = qwx_wmi_cmd_send(wmi, m, WMI_VDEV_DOWN_CMDID);
if (ret) {
- printf("%s: failed to submit WMI_VDEV_DOWN cmd\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to submit WMI_VDEV_DOWN cmd\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -18847,8 +18889,10 @@ qwx_wmi_vdev_stop(struct qwx_softc *sc, uint8_t vdev_i
ret = qwx_wmi_cmd_send(wmi, m, WMI_VDEV_STOP_CMDID);
if (ret) {
- printf("%s: failed to submit WMI_VDEV_STOP cmd\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to submit WMI_VDEV_STOP cmd\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -18935,8 +18979,10 @@ qwx_wmi_vdev_start(struct qwx_softc *sc, struct wmi_vd
ret = qwx_wmi_cmd_send(wmi, m, restart ?
WMI_VDEV_RESTART_REQUEST_CMDID : WMI_VDEV_START_REQUEST_CMDID);
if (ret) {
- printf("%s: failed to submit vdev_%s cmd\n",
- sc->sc_dev.dv_xname, restart ? "restart" : "start");
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to submit vdev_%s cmd\n",
+ sc->sc_dev.dv_xname, restart ? "restart" : "start");
+ }
m_freem(m);
return ret;
}
@@ -22593,8 +22639,11 @@ qwx_mac_11d_scan_start(struct qwx_softc *sc, struct qw
ret = qwx_wmi_send_11d_scan_start_cmd(sc, ¶m,
0 /* TODO: derive pdev ID from arvif somehow? */);
if (ret) {
- printf("%s: failed to start 11d scan; vdev: %d ret: %d\n",
- sc->sc_dev.dv_xname, arvif->vdev_id, ret);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to start 11d scan; vdev: %d "
+ "ret: %d\n", sc->sc_dev.dv_xname,
+ arvif->vdev_id, ret);
+ }
} else {
sc->vdev_id_11d_scan = arvif->vdev_id;
if (sc->state_11d == ATH11K_11D_PREPARING)
@@ -23932,8 +23981,10 @@ qwx_wmi_set_peer_param(struct qwx_softc *sc, uint8_t *
ret = qwx_wmi_cmd_send(wmi, m, WMI_PEER_SET_PARAM_CMDID);
if (ret) {
- printf("%s: failed to send WMI_PEER_SET_PARAM cmd\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send WMI_PEER_SET_PARAM cmd\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
return ret;
}
@@ -23976,8 +24027,11 @@ qwx_wmi_peer_rx_reorder_queue_setup(struct qwx_softc *
ret = qwx_wmi_cmd_send(wmi, m, WMI_PEER_REORDER_QUEUE_SETUP_CMDID);
if (ret) {
- printf("%s: failed to send WMI_PEER_REORDER_QUEUE_SETUP\n",
- sc->sc_dev.dv_xname);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to send "
+ "WMI_PEER_REORDER_QUEUE_SETUP\n",
+ sc->sc_dev.dv_xname);
+ }
m_freem(m);
}
@@ -24246,8 +24300,10 @@ qwx_scan(struct qwx_softc *sc)
ret = qwx_start_scan(sc, arg);
if (ret) {
- printf("%s: failed to start hw scan: %d\n",
- sc->sc_dev.dv_xname, ret);
+ if (ret != ESHUTDOWN) {
+ printf("%s: failed to start hw scan: %d\n",
+ sc->sc_dev.dv_xname, ret);
+ }
#ifdef notyet
spin_lock_bh(&ar->data_lock);
#endif
